-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defer integration tests #6007
base: dev
Are you sure you want to change the base?
defer integration tests #6007
Conversation
@Geal, please consider creating a changeset entry in |
@@ -582,7 +582,6 @@ impl IntegrationTest { | |||
|
|||
let mut request = builder.json(&query).build().unwrap(); | |||
telemetry.inject_context(&mut request); | |||
request.headers_mut().remove(ACCEPT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrynCooke do you remember why the integration tests were removing the Accept
header from the request?
interestingly, multer is unable to parse the multipart body we send with defer and subs:
it fails with the error |
the multer failure was due to a boundary reported as a quoted string |
Supporting subscriptions in those tests would be challenging, as they are not designed to execute tasks asynchronously, so we cannot(for now) use the HTTP callback while we are already waiting for a response. We could have subgraph emulation support websockets though |
This adds support for testing
@defer
in integration testsChecklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩