use the multi_thread executor to run the telemetry hang test #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test wasn't using the multi_thread executor, so eventually it would trip over the bug in opentelemetry which we've hit in the past where the runtime would hang for not fully understood reasons. see: open-telemetry/opentelemetry-rust#536 Using the multi_thread executor is the recommended work-around. I've also remove the redundant thread spawn from the telemetry Drop implementation, since I don't think it's required as well as the spawn_blocking() call. I've run this test in a tight loop for a couple of hours (on my M1 laptop) with no issues.
✅ Deploy Preview for apollo-router-docs canceled.
|
|
@garypen your pull request is missing a changelog! |
BrynCooke
approved these changes
Apr 27, 2022
bnjjj
approved these changes
Apr 27, 2022
o0Ignition0o
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test wasn't using the multi_thread executor, so eventually it would
trip over the bug in opentelemetry which we've hit in the past where the
runtime would hang for not fully understood reasons.
see: open-telemetry/opentelemetry-rust#536
Using the multi_thread executor is the recommended work-around.
I've also remove the redundant thread spawn from the telemetry Drop
implementation, since I don't think it's required as well as the
spawn_blocking() call.
I've run this test in a tight loop for a couple of hours (on my M1
laptop) with no issues.