ROVER-135 Make paths in supergraph.yaml resolve relative to the location of the file, not the current working directory of Rover #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs tests and will need a federation-rs PR merging to get it all aligned.
It appears these particular tests were relying on specific Windows line breaks etc. This is very error-prone, and in reality unnecessary as we can match on a smaller subset of the query itself and still get sensible answers.
jonathanrainer
added
feature 🎉
aaronArinder
approved these changes
Sep 10, 2024
dotdat
approved these changes
Sep 10, 2024
dotdat
pushed a commit
that referenced
this pull request
Sep 16, 2024
…ion of the file, not the current working directory of Rover (#2119) As per the title, to support integration with the Language Server we need to remove a 'quirk' of Rover whereby if you specify a file in the supergraph.yaml with a relative path, that path is resolved relative to the location that rover is running in at the time. This doesn't work in that context so instead we are changing it to resolve relative to the location of the supergraph.yaml file itself. I've added a unit test for this and run my own tests and it all seems to work ok. In addition I've fixed a test that has been broken for a long time, a more detailed write up on this test will follow Successful smoke test run: https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762
aaronArinder
pushed a commit
that referenced
this pull request
Sep 18, 2024
…ion of the file, not the current working directory of Rover (#2119) As per the title, to support integration with the Language Server we need to remove a 'quirk' of Rover whereby if you specify a file in the supergraph.yaml with a relative path, that path is resolved relative to the location that rover is running in at the time. This doesn't work in that context so instead we are changing it to resolve relative to the location of the supergraph.yaml file itself. I've added a unit test for this and run my own tests and it all seems to work ok. In addition I've fixed a test that has been broken for a long time, a more detailed write up on this test will follow Successful smoke test run: https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, to support integration with the Language Server we need to remove a 'quirk' of Rover whereby if you specify a file in the supergraph.yaml with a relative path, that path is resolved relative to the location that rover is running in at the time. This doesn't work in that context so instead we are changing it to resolve relative to the location of the supergraph.yaml file itself.
I've added a unit test for this and run my own tests and it all seems to work ok.
In addition I've fixed a test that has been broken for a long time, a more detailed write up on this test will follow
Successful smoke test run: https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762