Correctly check errors when building requests

appclacks · Jan 6, 2024 · d8f0a1e · d8f0a1e
1 parent 330555f
commit d8f0a1e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/client/client.go b/client/client.go
@@ -175,6 +175,9 @@ func (c *Client) sendRequest(ctx context.Context, url string, method string, bod
 		method,
 		fmt.Sprintf("%s%s", c.endpoint, url),
 		reqBody)
+	if err != nil {
+		return nil, err
+	}
 	if len(queryParams) != 0 {
 		q := request.URL.Query()
 		for k, v := range queryParams {
@@ -194,9 +197,6 @@ func (c *Client) sendRequest(ctx context.Context, url string, method string, bod
 		creds := base64.StdEncoding.EncodeToString([]byte(authString))
 		request.Header.Add("Authorization", fmt.Sprintf("Basic %s", creds))
 	}
-	if err != nil {
-		return nil, err
-	}
 	response, err := c.http.Do(request)
 	if err != nil {
 		return nil, err