♻️ Set push environment only when value is determined

appcues · Sep 17, 2024 · c3d3827 · c3d3827
1 parent 56f93cf
commit c3d3827
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/Sources/AppcuesKit/Data/Analytics/AutoPropertyDecorator.swift b/Sources/AppcuesKit/Data/Analytics/AutoPropertyDecorator.swift
@@ -147,10 +147,13 @@ internal class AutoPropertyDecorator: AnalyticsDecorating {
             "_deviceId": storage.deviceID,
             "_pushToken": pushToken,
             "_pushEnabled": pushMonitor.pushEnabled,
-            "_pushEnabledBackground": pushMonitor.pushBackgroundEnabled,
-            "_pushEnvironment": pushMonitor.pushEnvironment.environmentValue
+            "_pushEnabledBackground": pushMonitor.pushBackgroundEnabled
         ]
 
+        if let environment = pushMonitor.pushEnvironment.environmentValue {
+            properties["_pushEnvironment"] = environment
+        }
+
         if let language = deviceLanguage {
             properties["_language"] = language
         }

diff --git a/Sources/AppcuesKit/Push/PushEnvironment.swift b/Sources/AppcuesKit/Push/PushEnvironment.swift
@@ -37,12 +37,11 @@ internal enum PushEnvironment {
         }
     }
 
-    var environmentValue: String {
-        // The environment to request from the backend must be "development" or "production".
-        // If we haven't been able to determine the environment, default to "production".
+    var environmentValue: String? {
         switch self {
         case .development: return "development"
-        case .unknown, .production: return "production"
+        case .production: return "production"
+        case .unknown: return nil
         }
     }