Merge pull request #28 from fix/numerical-entities

appcues · Jul 24, 2017 · e55ba39 · e55ba39
2 parents 17687fc + f437d90
commit e55ba39
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/utils.js b/src/utils.js
@@ -15,7 +15,7 @@ export function transformName(name) {
 }
 
 // Regex for matching HTML entities.
-const entityRegex = new RegExp('&[a-z0-9]+;', 'gi')
+const entityRegex = new RegExp('&[a-z0-9#]+;', 'gi')
 // Element for setting innerHTML for transforming entities.
 let el = null;
 

diff --git a/test/tests/strings_test.js b/test/tests/strings_test.js
@@ -104,8 +104,8 @@ describe("#virtualizeString", () => {
     });
 
     it("should decode HTML entities, since VNodes just deal with text content", () => {
-        expect(virtualizeString("<div>&amp; is an ampersand! and &frac12; is 1/2!</div>")).to.deep.equal(
-            h('div', [ '& is an ampersand! and ½ is 1/2!' ])
+        expect(virtualizeString("<div>&amp; is an ampersand! and &frac12; is 1/2! and &#xA9; is copyright!</div>")).to.deep.equal(
+            h('div', [ '& is an ampersand! and ½ is 1/2! and © is copyright!' ])
         );
         expect(virtualizeString("<a href='http://example.com?test=true&amp;something=false'>Test</a>")).to.deep.equal(
             h('a', {