This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
snabbdom version ~0.6.6 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sauce doesn't seem to work in CI. Any thoughts on that? |
|
I would just skip testing in browsers altogether. I think that if a library is not using any DOM API then it should be fine to test it in Node.js. |
|
Well, I wasn't using that, but I see that "half" of the functionality is creating vnodes from DOM elements. So browser testing may be a good idea and should work in CI, as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This fixes a case of broken dependency specification.
In the same opportunity, it also deals with a breaking change in snabbdom, regarding its exports.