Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First PR #1

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

First PR #1

wants to merge 10 commits into from

Conversation

HrideshSingh
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2022

CLA assistant check
All committers have signed the CLA.

@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .idea folder

@@ -0,0 +1,59 @@
{
"app": {
"bundleName": "com.example.smart_wash_library",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide better bundle name like for example, com.ohos.lib.smart.wash

{
"app": {
"bundleName": "com.example.smart_wash_library",
"vendor": "example",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the vendor details

@@ -0,0 +1,6 @@
{
"strings": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused strings

left: 22px;
}
.tlabel3{
color: white; font-weight: 800; font-size: 20.3px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format code in all files and remove unnecessary blank lines

margin-left: 136.58px;
border:2px solid blue;
}
/*.slider {*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code in all places

@@ -0,0 +1,98 @@
<element src="../../../../../../../smartwash/js/index.hml" name="test"></element>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide proper name instead of test

@@ -0,0 +1,8 @@
export default {
data: {
title: ""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove title as its not used

</div>

<div class="menut">
<text class="time">10:00 PM</text>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont hardcode date... get the correct date from sdk's api and display.

<div class="full">
<div class="timer">
<image class="level_bg" src="/common/images/level_bg.png"></image>
<image class="Timmer_bg" src="/common/images/Timer_bg.png"></image>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the functionality like for example for wash type, user clicks on spin shall update UI accordingly.

<progress class="min-progress" type="ring" percent= "40" ></progress>
<image class="indication_point" src="/common/images/indication_point.png"></image>

<image src="/common/images/fill.png"class="fill"></image>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All such options displayed in UI, please maintain as array in js and use that to display in hml, instead of directly hardcoding over here


</div>

<div class="waterlevel">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maintain setter functions in js file to update data whenever user click happens like for example water level is changed, then setWaterLevel function should take care of updating data.

Also water level data displayed in UI should be defined in js and looped here to display

Copy link

@archanaatr archanaatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants