. t extract local vars

Co-Authored-By: Jay Bazuzi <jay@bazuzi.com>
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Joss Hufnagel <43077216+blade290@users.noreply.github.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>

tests/test_fileapprover.py

@@ -57,17 +57,20 @@ def test_approved_file_is_logged(self):
         name = approvals.get_default_namer().get_approved_filename()
         log = ApprovedFilesLog.get_approved_files_log()
         log_lines = log.read_text().split("\n")
-        self.assertNotIn(name.replace(".txt", ".txt1"), log_lines)
-        self.assertNotIn(name.replace(".txt", ".txt2"), log_lines)
+        name1 = name.replace(".txt", ".txt1")
+        name2 = name.replace(".txt", ".txt2")
+
+        # check log is cleared
+        self.assertNotIn(name1, log_lines)
+        self.assertNotIn(name2, log_lines)
 
         # touch approved file
         verify("a", options=Options().for_file.with_extension(".txt1"))
         verify("a", options=Options().for_file.with_extension(".txt2"))
 
         # assert that the approved file is logged
         log_lines = log.read_text().split("\n")
-        self.assertIn(name.replace(".txt", ".txt1"), log_lines)
-        self.assertIn(name.replace(".txt", ".txt2"), log_lines)
-
+        self.assertIn(name1, log_lines)
+        self.assertIn(name2, log_lines)