-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor serving of Rack response bodies #1037
Merged
Merged
Commits on Feb 14, 2024
-
Monitor serving of Rack response bodies
Some work might be getting done within a Rack response body. For example, when ActionController::Streaming is used, or when a Rack app elects to stream a response. The Rack SPEC doc actually defines the behavior in sufficient detail to wrap this into the same Appsignal transaction. Sadly, there is some work involved in supporting all the right methods, so just "one-size-fits-all" wrapper will not quite work
Configuration menu - View commit details
-
Copy full SHA for 7da96e7 - Browse repository at this point
Copy the full SHA 7da96e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 906599b - Browse repository at this point
Copy the full SHA 906599bView commit details -
Complete txn on errors outside of body
and include Sinatra-related integration changes If there is an exception within `call` of a Rack app, the body won't be returned. And that will be the case 99% of the time. If that happens we need to complete the transaction early to ensure data is sent across, as there is no BodyWrapper to complete it for us.
Configuration menu - View commit details
-
Copy full SHA for 7dce82e - Browse repository at this point
Copy the full SHA 7dce82eView commit details -
Instrument the output of the body wrapper
Some work might be getting done inside the body (like when serving a ZIP). We want this work to paint properly on the sample waterfall in the Appsignal UI, so surround those with `instrument`.
Configuration menu - View commit details
-
Copy full SHA for 8e86efd - Browse repository at this point
Copy the full SHA 8e86efdView commit details
Commits on Feb 15, 2024
-
Co-authored-by: Tom de Bruijn <tom@tomdebruijn.com>
Configuration menu - View commit details
-
Copy full SHA for 7e46325 - Browse repository at this point
Copy the full SHA 7e46325View commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for db858c9 - Browse repository at this point
Copy the full SHA db858c9View commit details
Commits on Feb 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f33d4f0 - Browse repository at this point
Copy the full SHA f33d4f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8f525d - Browse repository at this point
Copy the full SHA f8f525dView commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ac06c1 - Browse repository at this point
Copy the full SHA 7ac06c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee1eba2 - Browse repository at this point
Copy the full SHA ee1eba2View commit details
Commits on Feb 22, 2024
-
which - it would seem - requires another conditional, but it doesn't.
Configuration menu - View commit details
-
Copy full SHA for 61cc148 - Browse repository at this point
Copy the full SHA 61cc148View commit details -
Configuration menu - View commit details
-
Copy full SHA for a45ab0d - Browse repository at this point
Copy the full SHA a45ab0dView commit details -
Add changeset for PR appsignal#1037
Add changeset so the change can be released and is shown in the CHANGELOG.md file upon release.
Configuration menu - View commit details
-
Copy full SHA for 9984156 - Browse repository at this point
Copy the full SHA 9984156View commit details -
Configuration menu - View commit details
-
Copy full SHA for d26be0a - Browse repository at this point
Copy the full SHA d26be0aView commit details -
I mistyped the titles for the events in my comment on the GitHub issue. This is what I meant to type.
Configuration menu - View commit details
-
Copy full SHA for 63ed863 - Browse repository at this point
Copy the full SHA 63ed863View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.