Supported nested Rack EventHandlers #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case that an app, for whatever reason, has nested Rack EventHandlers, handle this properly. This change makes it so that the EventHandler doesn't create multiple transactions if it's nested inside another EventHandler. It does this by assigning itself an ID (UUID), and adding it to the request environment. Then, on every callback it receives, it checks if it is the first EventHandler that handled the request. Only then does it do any instrumentation. This will help with accidental multiple registrations of the AppSignal Rack EventHandler in one app, like with nested apps. It also opens the door for automatically registering the EventHandler for other gems, like Sinatra.
This was referenced Jun 19, 2024
luismiramirez
approved these changes
Jun 20, 2024
unflxw
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that an app, for whatever reason, has nested Rack EventHandlers, handle this properly.
This change makes it so that the EventHandler doesn't create multiple transactions if it's nested inside another EventHandler. It does this by assigning itself an ID (UUID), and adding it to the request environment. Then, on every callback it receives, it checks if it is the first EventHandler that handled the request. Only then does it do any instrumentation.
This will help with accidental multiple registrations of the AppSignal Rack EventHandler in one app, like with nested apps. It also opens the door for automatically registering the EventHandler for other gems, like Sinatra.
Part of #329