Fix Sinatra instrumentation causing boot loop #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed in our test setup that when I added a Sinatra app to the Rails app, and loaded the Sinatra instrumentation as specified in our docs it would get stuck in a boot loop. This was caused by the two different configs overwriting each other every time. Prevent this issue by skipping loading the AppSignal config if it's already active.
luismiramirez
approved these changes
Jun 21, 2024
tombruijn
added a commit
that referenced
this pull request
Jun 27, 2024
When AppSignal is already active, do not start AppSignal again. This is a good precaution as it prevents boot loops, when AppSignal is started twice with different configurations. This will improve support for nested Hanami applications, when they're mounted in another frameworks we support, like Rails or Sinatra. This is similar to PR #1105 Part of #329
tombruijn
added a commit
that referenced
this pull request
Jun 27, 2024
When AppSignal is already active, do not start AppSignal again. This is a good precaution as it prevents boot loops, when AppSignal is started twice with different configurations. This will improve support for nested Hanami applications, when they're mounted in another frameworks we support, like Rails or Sinatra. This is similar to PR #1105 Part of #329
tombruijn
added a commit
that referenced
this pull request
Jun 28, 2024
When AppSignal is already active, do not start AppSignal again. This is a good precaution as it prevents boot loops, when AppSignal is started twice with different configurations. This will improve support for nested Hanami applications, when they're mounted in another frameworks we support, like Rails or Sinatra. This is similar to PR #1105 Part of #329
tombruijn
added a commit
that referenced
this pull request
Jul 3, 2024
Apply the same boot loop fix as for Sinatra for Padrino from PR #1105. For Sinatra apps noticed in our test setup that when I added a Sinatra app to the Rails app, and loaded the Sinatra instrumentation as specified in our docs it would get stuck in a boot loop. This was caused by the two different configs overwriting each other every time. Apply the same fix for Padrino by checking first if AppSignal has already started and skipping the auto start.
tombruijn
added a commit
that referenced
this pull request
Jul 4, 2024
Apply the same boot loop fix as for Sinatra for Padrino from PR #1105. For Sinatra apps noticed in our test setup that when I added a Sinatra app to the Rails app, and loaded the Sinatra instrumentation as specified in our docs it would get stuck in a boot loop. This was caused by the two different configs overwriting each other every time. Apply the same fix for Padrino by checking first if AppSignal has already started and skipping the auto start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in our test setup that when I added a Sinatra app to the Rails app, and loaded the Sinatra instrumentation as specified in our docs it would get stuck in a boot loop. This was caused by the two different configs overwriting each other every time.
Prevent this issue by skipping loading the AppSignal config if it's already active.