Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hanami to use Rack middleware #1113

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Update Hanami to use Rack middleware #1113

merged 2 commits into from
Jun 26, 2024

Commits on Jun 25, 2024

  1. Update Hanami to use Rack middleware 

    As part of #329, update the Hanami integration to use Rack middleware
and the EventHandler to instrument requests made to Hanami apps. This
standardizes the instrumentation as much as possible between Rack apps
and minimizes our reliance on monkeypatches.

The only monkeypatch that remains is setting the action name to the
Action class name. I have found no other way yet to fetch this metadata
from the request metadata, environment or the Hanami router.

Part of #329
Mostly solves #911
    @tombruijn
    tombruijn committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e79d427 View commit details
    Browse the repository at this point in the history

  2. Add test for Hanami middleware not being installed 

    Add a test that makes sure we don't install the middleware on the Hanami
app when AppSignal is not active.
    @tombruijn
    tombruijn committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3cc91d3 View commit details
    Browse the repository at this point in the history