Don't report middleware event for Rails #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in PR #1107, do not create a transaction event for a Rails apps using the RailsInstrumentation middleware. The ActiveSupport Notifications and Rack EventHandler events are enough. The `middleware.rails` event didn't add much. Closes #1120 [skip changeset] because the related change in PR #1107 has not been released yet.
luismiramirez
approved these changes
Jun 28, 2024
tombruijn
added a commit
that referenced
this pull request
Jul 2, 2024
In PR #1124, I added functionality to not report an instrumentation event for the Rails instrumentation middleware. The AbstractMiddleware shouldn't be used on its own, but it did have a default for reporting instrumentation events. Remove that default so it doesn't report an event by default. [skip changeset] It's an internal change to the AbstractMiddleware and no one should be using that directly.
tombruijn
added a commit
that referenced
this pull request
Jul 3, 2024
In PR #1124, I added functionality to not report an instrumentation event for the Rails instrumentation middleware. The AbstractMiddleware shouldn't be used on its own, but it did have a default for reporting instrumentation events. Remove that default so it doesn't report an event by default. [skip changeset] It's an internal change to the AbstractMiddleware and no one should be using that directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #1107, do not create a transaction event for a Rails apps using the RailsInstrumentation middleware. The ActiveSupport Notifications and Rack EventHandler events are enough. The
middleware.railsevent didn't add much.Closes #1120
[skip changeset] because the related change in PR #1107 has not been released yet.