Report response status when there is no response #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no response object given to the EventHandler's `on_finish` callback, we can expect an unhandled error has occurred. When have also received an exception in the `on_error` callback, report the response status as 500. This solution is not perfect. It may actually be another response status if something else above the EventHandler handles the exception. A setup we don't recommend.
tombruijn
force-pushed
the
report-error-response-status
branch
from
7076077
to
6e67999
Compare
luismiramirez
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no response object given to the EventHandler's
on_finishcallback, we can expect an unhandled error has occurred.When have also received an exception in the
on_errorcallback, report the response status as 500. This solution is not perfect. It may actually be another response status if something else above the EventHandler handles the exception. A setup we don't recommend.Part of #329