Remove backtrace cleaner filter after test #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an issue adding a spec with the line number "123". It would be replaced with "1?3" whenever Rails was loaded. That's because this spec left the filters in the cleaner's config. Disable the filter after the spec has completed. I could go into the backtrace cleaner internals and remove the lambda from the `@filters` instance variable, but this solution with our global store that's only set to true for this spec is fine. The store is cleared after every spec. [skip changeset]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue adding a spec with the line number "123". It would be replaced with "1?3" whenever Rails was loaded. That's because this spec left the filters in the cleaner's config.
Disable the filter after the spec has completed. I could go into the backtrace cleaner internals and remove the lambda from the
@filtersinstance variable, but this solution with our global store that's only set to true for this spec is fine. The store is cleared after every spec.[skip changeset]
[skip review]