Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuring instrument redis and sequel from env #257

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Fix configuring instrument redis and sequel from env #257

merged 1 commit into from
Feb 27, 2017

Conversation

thijsc
Copy link
Member

@thijsc thijsc commented Feb 20, 2017

Fixes #251

tombruijn
tombruijn approved these changes Feb 20, 2017
View reviewed changes
Copy link
Member

@tombruijn tombruijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good for now. I think we can maybe prevent this in the future by changing the spec to (also) check the env vars in the Appsignal::Config::ENV_TO_KEY_MAPPING constant, to see if we've tested them all. Anyway, not a required change for this fix.

@tombruijn tombruijn merged commit 7dc4f9f into master Feb 27, 2017
@tombruijn tombruijn deleted the fix_instrument_sequel_env_var branch February 27, 2017 10:28
@tombruijn tombruijn mentioned this pull request Jun 27, 2017
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsimitsu matsimitsu matsimitsu approved these changes

@tombruijn tombruijn tombruijn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thijsc @matsimitsu @tombruijn