Add streaming endpoints for Rails/Sinatra #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I don't think we'll need an endpoint to test this on every rails app. Just one app per Rails version would be fine. I'd keep it in only the rails6-mysql, rails7-postgres and sinatra apps. |
tombruijn
reviewed
Feb 14, 2024
Co-authored-by: Tom de Bruijn <tom@tomdebruijn.com>
|
Closing in favor of #187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to use the prescribed setup but for some reason i.e. Puma inside Docker is not able to bind to the socket when I start it. There are also a few shenanigans because Sinatra installs 4.0.0 by default, which pulls in Rack 3. This makes for a good test case but I don't know whether Appsignal is Rack 3.x compatible as of now... it should be (esp. including the changes I am making in the agent) but could use extra verification.