Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add flowchart #24

Merged
merged 8 commits into from
Jul 25, 2024
Merged

docs: add flowchart #24

merged 8 commits into from
Jul 25, 2024

Conversation

knqyf263
Copy link
Collaborator

No description provided.

@knqyf263 knqyf263 self-assigned this Jul 22, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diagram content is good for me.
Left comment about appearance.

README.md Outdated

classDef dev fill:#e6f3ff,stroke:#333,stroke-width:1px;
classDef vexHub fill:#fff0f5,stroke:#333,stroke-width:1px;
classDef crawler fill:#e6ffe6,stroke:#333,stroke-width:1px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using a different background color.
header not visible in dark theme:
изображение

same for sourceRepo

Copy link
Collaborator Author

@knqyf263 knqyf263 Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using a different background color. header not visible in dark theme:

I updated the color, but then, it was no longer light-mode friendlly. It looks like others are also facing the same problem.

As far as I know, GitHub doesn't support dark mode, and most people see this diagram on GitHub. I believe it's fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, GitHub doesn't support dark mode

I use dark theme on my PC and GH uses system theme (you can see all themes here - https://github.com/settings/appearance).
That is why i saw problem with background.

But now it looks better:
изображение

Copy link
Collaborator Author

@knqyf263 knqyf263 Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I tried dark mode on GitHub, but didn't like it, and probably changed it back😄

Copy link
Contributor

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but added some small comments for your consideration

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 22 to 24
subgraph Src [Source Repository]
Dir[.vex/ directory] -->|Store| Doc[VEX documents]
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure a subgraph helps here, maybe simplify with just a text that demonstrates the .vex dir path?
anyway, shouldn't it be /.vex instead of .vex/

knqyf263 and others added 6 commits July 25, 2024 09:22
Co-authored-by: Itay Shakury <itay@itaysk.com>
Co-authored-by: Itay Shakury <itay@itaysk.com>
Co-authored-by: Itay Shakury <itay@itaysk.com>
Co-authored-by: Itay Shakury <itay@itaysk.com>
Co-authored-by: Itay Shakury <itay@itaysk.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
Copy link
Collaborator Author

knqyf263 commented Jul 25, 2024

The direction of the arrow changes the layout significantly. As far as I know, it is difficult to get the layout to do what we want in Mermaid.js.

CleanShot 2024-07-25 at 09 48 49

I know that some parts are not technically correct, but I will go with this diagram for now.

@knqyf263 knqyf263 merged commit 6c04cf2 into main Jul 25, 2024
2 checks passed
@knqyf263 knqyf263 deleted the doc_flowchart branch July 25, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants