Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT Vault app smart contracts #44

Closed
izqui opened this issue Dec 2, 2017 · 7 comments
Closed

NFT Vault app smart contracts #44

izqui opened this issue Dec 2, 2017 · 7 comments

Comments

@izqui
Copy link
Contributor

izqui commented Dec 2, 2017

ERC721 defines the standard for Non-Fungible Tokens (NFTs). By supporting ERC721 Aragon organizations will be able to manage NFTs.

Decentraland's LAND and Cryptokitties both use ERC721 NFTs and seems like it will become the standard for future tokens.

Check the Token Vault for reference and inspiration

@onbjerg
Copy link
Contributor

onbjerg commented Dec 2, 2017

You had me at cryptokitties 💻🐱

@onbjerg
Copy link
Contributor

onbjerg commented Dec 3, 2017

This should probably also be reflected in the finance app somehow, or maybe we need a separate app for NFTs. What do you think would make more sense?

Given NFTs will rarely be used in a budget, it probably makes more sense to have a dedicated NFT app to list your NFTs.

Thankfully, ERC721 specifies names, descriptions and images for the different NFTs, so it would probably be trivial to list them at least.

@sohkai
Copy link
Contributor

sohkai commented Dec 6, 2017

It probably makes more sense to have a dedicated NFT app to list your NFTs.

I totally agree. I highly doubt NFTs will be used to manage anything financial, in the way the current finance app works (accounting for payments in and out). Maybe something like "Assets" that sits alongside Tokens?

@onbjerg
Copy link
Contributor

onbjerg commented Dec 8, 2017

I like the name "Assets" except assets could also cover cash reserves, so it might be confusing.

@izqui izqui changed the title Add ERC721 support to Vault Add ERC821 support to Vault Feb 6, 2018
@izqui izqui changed the title Add ERC821 support to Vault ERC721 vault Mar 12, 2018
@izqui
Copy link
Contributor Author

izqui commented Mar 12, 2018

ERC721 was just merged. We need an ERC721 vault :) ethereum/EIPs#841

@izqui izqui added the bounty label Mar 12, 2018
@status-open-bounty
Copy link

status-open-bounty commented Mar 12, 2018

Current balance: 0.000000 ETH
Tokens: ANT: 70.00
Contract address: 0xbc8e96e851fb113943fb6d55493f541eb149b0fa
QR Code
Network: Mainnet
To claim this bounty sign up at https://openbounty.status.im and make sure to update your Ethereum address in My Payment Details so that the bounty is correctly allocated.
To fund it, send ETH or ERC20/ERC223 tokens to the contract address.

@izqui izqui changed the title ERC721 vault NFT Vault app smart contracts Mar 12, 2018
@fcolavecchia
Copy link

Hi!, a very interesting problem, I would give it a try, if none at the core team is able to do it. The idea would be to borrow the ERC721 standard implementation from our zeppelin cousins, and build the NTF Vault (Inventory app?) from there, adding the basic functionality.
Sounds ok, @izqui ?

bingen pushed a commit to bingen/aragon-apps that referenced this issue Dec 17, 2018
* WIP add token to DAO

* WIP bump aragon-cli version and add tokens to DAO

* Seed employees and tokens to DAO

* Bump aragon cli version

* Add allowed tokens

* Use entity domain as employee name

* Fix Payroll tests after merge master

* Fix Payroll tests, change role name

* Fix more tests

* Start with 9 accounts and add accounts to entities mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants