Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all dependencies to lib directory and make interface contracts interface types #193

Merged
merged 7 commits into from
Jan 16, 2018
Merged

Move all dependencies to lib directory and make interface contracts interface types #193

merged 7 commits into from
Jan 16, 2018

Conversation

izqui
Copy link
Contributor

@izqui izqui commented Jan 16, 2018 •
edited
Loading

Close #170, close #187

ERC677 contracts haven't been modified as they will be removed with #163

@izqui izqui added this to the 0.5 code freeze milestone Jan 16, 2018
@izqui izqui requested a review from sohkai January 16, 2018 12:27
@izqui izqui mentioned this pull request Jan 16, 2018
Closed
@izqui izqui changed the title Make interface contracts interface types Move all dependencies to lib directory and make interface contracts interface types Jan 16, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+7.6%) to 94.352% when pulling df51ab2 on ints into 391142a on dev.

sohkai
sohkai approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sohkai sohkai merged commit c09d0e5 into dev Jan 16, 2018
@sohkai sohkai deleted the ints branch April 15, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
aragonOS 3.0
Development

Successfully merging this pull request may close these issues.

Isolate all dependencies in lib directory Use interfaces instead of interface contracts
3 participants
@izqui @coveralls @sohkai