tests: Coverage improvements #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
commented
Feb 8, 2019
| @@ -326,37 +336,23 @@ contract('EVM Script', accounts => { | |||
| }) | |||
| }) | |||
|
|
|||
| context('registry', () => { | |||
| it('can be disabled', async () => { | |||
| context('> Registry actions', () => { | |||
There was a problem hiding this comment.
Note that these tests have been simplified as most of the functionality was already tested earlier.
sohkai
commented
Feb 8, 2019
| @@ -1,31 +1,49 @@ | |||
| pragma solidity 0.4.24; | |||
There was a problem hiding this comment.
This mock has been refactored to be simpler, and more targeted about what's missing.
sohkai
force-pushed
the
coverage-improvements
branch
from
2042452
to
76bac53
Compare
sohkai
added a commit
that referenced
this pull request
Mar 8, 2019
* APMRegistry: fix tests checking APMRegistry doesn't init without required permissions * EVMScriptRegistry: add more tests for coverage * ENSSubdomainRegistrary: fix initialization test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the coverage of some missing branches.