ACL: revert if attempting to save empty params #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izqui
approved these changes
Mar 27, 2019
facuspagnuolo
approved these changes
Mar 29, 2019
Co-Authored-By: sohkai <qisheng.brett.sun@gmail.com>
sohkai
force-pushed
the
acl-revert-on-saving-empty-params
branch
from
ded7a42
to
c72ac63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0x290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563is actuallykeccak256([0]), rather thankeccak256([]). However, it looks likeweb3-utils@1.0.0-beta.33doesn't really know the difference either :/