Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing improvements #542

Open
wants to merge 9 commits into
base: next
Choose a base branch
from
Open

Testing improvements #542

wants to merge 9 commits into from

Conversation

dapplion
Copy link

@dapplion dapplion commented Jul 13, 2019 •
edited
Loading

Following the request on the "good first issue" #514, I am extending the tests covering the following items:

  • Explicitly test AppProxyFactory. newAppProxyPinned(IKernel, bytes32)
  • Explicitly test EVMScriptRunner.protectState modifier
  • Test view methods of SafeERC20.sol

NOTE: This PR is a WIP until further questions are resolved.

@welcome
Copy link

welcome bot commented Jul 13, 2019

Thanks for opening this pull request! Someone will review it soon 🔍

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jul 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 100.0% when pulling 6d84a85 on dapplion:514_testing_improvements into 0fd1ff6 on aragon:next.

@dapplion dapplion mentioned this pull request Jul 13, 2019
Open
facuspagnuolo
facuspagnuolo reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @dapplion ! Looking forward for the other tests :)

@dapplion
Copy link
Author

@sohkai The Travis build on my fork's branch completes the coverage step successfully https://travis-ci.com/dapplion/aragonOS/builds/125316450. However, on your repo it doesn't, where it errors with:

Writing artifacts to ./build/contracts
Instrumenting  ./coverageEnv/contracts/acl/ACL.sol
Skipping instrumentation of  ./coverageEnv/contracts/acl/ACLSyntaxSugar.sol
Instrumenting  ./coverageEnv/contracts/acl/IACL.sol
Cleaning up...
There was a problem instrumenting ./coverageEnv/contracts/acl/IACL.sol: TypeError: Cannot read property 'stop' of null
Exiting without generating coverage...
npm ERR! code ELIFECYCLE

Do you have any clue on what might be the issue? With this last commit, coverage gets to 100.00% :)

@dapplion
Copy link
Author

@cgewecke helped solve the problem and now of CI tasks complete successfully

@sohkai sohkai added this to the aragonOS 5.0 milestone Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facuspagnuolo facuspagnuolo facuspagnuolo left review comments

@izqui izqui Awaiting requested review from izqui

@sohkai sohkai Awaiting requested review from sohkai

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
aragonOS 5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dapplion @CLAassistant @coveralls @facuspagnuolo @sohkai @cgewecke