move to dev dependency

[novaknole]

Description

After doing this, I realized one thing. If you install @aragon/osx, it's true, it brings the contracts in the node_modules, but they won't work unless consumer of our package installs openzeppelin packages by himself. Isn't the whole idea why dev would install our package to build on top of it ?

Maybe in the packages/contracts/src/package.json, we should put OZ packages in the dependencies .

@brickpop @mathewmeconry

Task: ID

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran all tests with success and extended them if necessary.
• I have updated the CHANGELOG.md file in the root folder.
• I have tested my code on the test network.

[mathewmeconry]

Yep agreed. We need to add the contracts we inherit from in the dependencies of the osx package

[brickpop]

• I think package.json file is already OK the way it is.
• But we should indeed update packages/contracts/src/package.json to have OZ as a dependency. This is what people is going to import for the contract source files 👍 @novaknole