Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-206: test dao with extended schema (part-1) #354

Merged
merged 4 commits into from
Apr 20, 2023
Merged

OS-206: test dao with extended schema (part-1) #354

merged 4 commits into from
Apr 20, 2023

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Apr 17, 2023 •
edited
Loading

Description

Task: OS-206

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

brickpop
brickpop previously approved these changes Apr 19, 2023
View reviewed changes
packages/subgraph/tests/dao/dao_v1_0_0.test.ts Show resolved Hide resolved
josemarinas
josemarinas previously approved these changes Apr 20, 2023
View reviewed changes
@Rekard0 Rekard0 dismissed stale reviews from josemarinas and brickpop via acaac9c April 20, 2023 12:46
@Rekard0 Rekard0 merged commit 05eabef into develop Apr 20, 2023
@brickpop brickpop deleted the f/OS-206_test-dao-with-extended-schema branch April 20, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

@josemarinas josemarinas josemarinas approved these changes

@heueristik heueristik Awaiting requested review from heueristik

Assignees
No one assigned
Labels
subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rekard0 @brickpop @josemarinas