F/ OS-380 npm package versions #361

Rekard0 · 2023-04-26T10:22:38Z

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-380

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

I have selected the correct base branch.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
Any dependent changes have been merged and published in downstream modules.
I ran all tests with success and extended them if necessary.
I have updated the CHANGELOG.md file in the root folder.
I have tested my code on the test network.

heueristik · 2023-04-26T15:53:27Z

Merging this branch into my feature/OS-358-nonreentrant-executor branch, and executing yarn build, I get the following errors:

contracts-versions git:(feature/OS-358-nonreentrant-executor) yarn build
yarn run v1.22.19
$ yarn build:contracts && yarn build:npm
$ node create-contract-versions.js
Building contracts for version: v0.7.0_alpha, with commit: 9b912728c315f983af8c4bfd1f8d07021996563f
Error building contracts: Error: Command failed: git checkout 9b912728c315f983af8c4bfd1f8d07021996563f
error: The following untracked working tree files would be overwritten by checkout:
        Readme.md
Please move or remove them before you switch branches.
Aborting

    at ChildProcess.exithandler (node:child_process:398:12)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
  code: 1,
  killed: false,
  signal: null,
  cmd: 'git checkout 9b912728c315f983af8c4bfd1f8d07021996563f',
  stdout: '',
  stderr: 'error: The following untracked working tree files would be overwritten by checkout:\n' +
    '\tReadme.md\n' +
    'Please move or remove them before you switch branches.\n' +
    'Aborting\n'
}
Copying active_contracts.json
Building contracts for version: v1.0.0_mainnet_goerli, with commit: c2b9d23a96654e81f22fbf91e6f334ef26a370af
Error building contracts: Error: Command failed: git checkout c2b9d23a96654e81f22fbf91e6f334ef26a370af
error: The following untracked working tree files would be overwritten by checkout:
        Readme.md
Please move or remove them before you switch branches.
Aborting

    at ChildProcess.exithandler (node:child_process:398:12)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
  code: 1,
  killed: false,
  signal: null,
  cmd: 'git checkout c2b9d23a96654e81f22fbf91e6f334ef26a370af',
  stdout: '',
  stderr: 'error: The following untracked working tree files would be overwritten by checkout:\n' +
    '\tReadme.md\n' +
    'Please move or remove them before you switch branches.\n' +
    'Aborting\n'
}
Copying active_contracts.json
Building contracts for version: v1.0.0_mumbai, with commit: 9485d97301611cfc78faa4bd00eb54abb6dd2d5e
Copying active_contracts.json
$ rollup --config rollup.config.ts

npm/index.ts → dist, dist...
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
ethers (imported by build/v0.7.0_alpha/types/factories/GovernanceERC20__factory.ts, build/v0.7.0_alpha/types/factories/IGovernanceWrappedERC20__factory.ts, build/v0.7.0_alpha/types/factories/GovernanceWrappedERC20__factory.ts, build/v0.7.0_alpha/types/factories/IERC20MintableUpgradeable__factory.ts, build/v0.7.0_alpha/types/factories/IEIP4824__factory.ts, build/v0.7.0_alpha/types/factories/DAO__factory.ts, build/v0.7.0_alpha/types/factories/IDAO__factory.ts, build/v0.7.0_alpha/types/factories/PluginCloneable__factory.ts, build/v0.7.0_alpha/types/factories/Plugin__factory.ts, build/v0.7.0_alpha/types/factories/IPlugin__factory.ts, build/v0.7.0_alpha/types/factories/IProposal__factory.ts, build/v0.7.0_alpha/types/factories/Proposal__factory.ts, build/v0.7.0_alpha/types/factories/ProposalUpgradeable__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeable__factory.ts, build/v0.7.0_alpha/types/factories/DaoAuthorizable__factory.ts, build/v0.7.0_alpha/types/factories/DaoAuthorizableUpgradeable__factory.ts, build/v0.7.0_alpha/types/factories/IMembership__factory.ts, build/v0.7.0_alpha/types/factories/CallbackHandler__factory.ts, build/v0.7.0_alpha/types/factories/IPermissionCondition__factory.ts, build/v0.7.0_alpha/types/factories/PermissionLib__factory.ts, build/v0.7.0_alpha/types/factories/PermissionManager__factory.ts, build/v0.7.0_alpha/types/factories/TestERC721__factory.ts, build/v0.7.0_alpha/types/factories/TestERC1155__factory.ts, build/v0.7.0_alpha/types/factories/TestERC20__factory.ts, build/v0.7.0_alpha/types/factories/GovernanceERC20Mock__factory.ts, build/v0.7.0_alpha/types/factories/CallbackHandlerMockHelper__factory.ts, build/v0.7.0_alpha/types/factories/DAOMock__factory.ts, build/v0.7.0_alpha/types/factories/GasConsumer__factory.ts, build/v0.7.0_alpha/types/factories/ERC1271Mock__factory.ts, build/v0.7.0_alpha/types/factories/ActionExecute__factory.ts, build/v0.7.0_alpha/types/factories/AdminCloneFactory__factory.ts, build/v0.7.0_alpha/types/factories/MajorityVotingMock__factory.ts, build/v0.7.0_alpha/types/factories/TestPlugin__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeableV1Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeableV3Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeableV2Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeableSetupV4Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeableSetupV3Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeableSetupV2Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeableSetupV1MockBad__factory.ts, build/v0.7.0_alpha/types/factories/PluginUUPSUpgradeableSetupV1Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginCloneableV2Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginCloneableV1MockBad__factory.ts, build/v0.7.0_alpha/types/factories/PluginCloneableV1Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginCloneableSetupV1MockBad__factory.ts, build/v0.7.0_alpha/types/factories/PluginCloneableSetupV2Mock__factory.ts, build/v0.7.0_alpha/types/factories/PluginCloneableSetupV1Mock__factory.ts, build/v0.7.0_alpha/types/factories/AddresslistMock__factory.ts, build/v0.7.0_alpha/types/factories/TestSharedPlugin__factory.ts, build/v0.7.0_alpha/types/factories/TestIdGatingCondition__factory.ts, build/v0.7.0_alpha/types/factories/RegistryUtils__factory.ts, build/v0.7.0_alpha/types/factories/RatioTest__factory.ts, build/v0.7.0_alpha/types/factories/InterfaceBasedRegistryMock__factory.ts, build/v0.7.0_alpha/types/factories/PermissionManagerTest__factory.ts, build/v0.7.0_alpha/types/factories/PermissionConditionMock__factory.ts, build/v0.7.0_alpha/types/factories/TestParameterScopingPermissionCondition__factory.ts, build/v0.7.0_alpha/types/factories/DAORegistry__factory.ts, build/v0.7.0_alpha/types/factories/DAOFactory__factory.ts, build/v0.7.0_alpha/types/factories/PluginSetup__factory.ts, build/v0.7.0_alpha/types/factories/IPluginSetup__factory.ts, build/v0.7.0_alpha/types/factories/PluginSetupProcessor__factory.ts, build/v0.7.0_alpha/types/factories/IPluginRepo__factory.ts, build/v0.7.0_alpha/types/factories/PluginRepoFactory__factory.ts, build/v0.7.0_alpha/types/factories/PluginRepoRegistry__factory.ts, build/v0.7.0_alpha/types/factories/PluginRepo__factory.ts, build/v0.7.0_alpha/types/factories/ENSSubdomainRegistrar__factory.ts, build/v0.7.0_alpha/types/factories/InterfaceBasedRegistry__factory.ts, build/v0.7.0_alpha/types/factories/TokenFactory__factory.ts, build/v0.7.0_alpha/types/factories/MerkleMinter__factory.ts, build/v0.7.0_alpha/types/factories/IMerkleDistributor__factory.ts, build/v0.7.0_alpha/types/factories/IMerkleMinter__factory.ts, build/v0.7.0_alpha/types/factories/MerkleDistributor__factory.ts, build/v0.7.0_alpha/types/factories/Addresslist__factory.ts, build/v0.7.0_alpha/types/factories/CounterV1__factory.ts, build/v0.7.0_alpha/types/factories/CounterV1PluginSetup__factory.ts, build/v0.7.0_alpha/types/factories/CounterV2__factory.ts, build/v0.7.0_alpha/types/factories/CounterV2PluginSetup__factory.ts, build/v0.7.0_alpha/types/factories/MultiplyHelper__factory.ts, build/v0.7.0_alpha/types/factories/PlaceholderSetup__factory.ts, build/v0.7.0_alpha/types/factories/AdminSetup__factory.ts, build/v0.7.0_alpha/types/factories/Admin__factory.ts, build/v0.7.0_alpha/types/factories/Multisig__factory.ts, build/v0.7.0_alpha/types/factories/IMultisig__factory.ts, build/v0.7.0_alpha/types/factories/MultisigSetup__factory.ts, build/v0.7.0_alpha/types/factories/TokenVoting__factory.ts, build/v0.7.0_alpha/types/factories/TokenVotingSetup__factory.ts, build/v0.7.0_alpha/types/factories/MajorityVotingBase__factory.ts, build/v0.7.0_alpha/types/factories/AddresslistVoting__factory.ts, build/v0.7.0_alpha/types/factories/AddresslistVotingSetup__factory.ts, build/v0.7.0_alpha/types/factories/IMajorityVoting__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/GovernanceERC20__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IGovernanceWrappedERC20__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/GovernanceWrappedERC20__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IERC20MintableUpgradeable__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IEIP4824__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/DAO__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IDAO__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginCloneable__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/Plugin__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IPlugin__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IProposal__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/Proposal__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/ProposalUpgradeable__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeable__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/DaoAuthorizable__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/DaoAuthorizableUpgradeable__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IMembership__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/CallbackHandler__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IPermissionCondition__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PermissionLib__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PermissionManager__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TestERC721__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TestERC1155__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TestERC20__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/GovernanceERC20Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/CallbackHandlerMockHelper__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/DAOMock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/GasConsumer__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/ERC1271Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/ActionExecute__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/AdminCloneFactory__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/MajorityVotingMock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TestPlugin__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeableV1Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeableV3Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeableV2Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeableSetupV4Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeableSetupV3Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeableSetupV2Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeableSetupV1MockBad__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginUUPSUpgradeableSetupV1Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginCloneableV2Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginCloneableV1MockBad__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginCloneableV1Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginCloneableSetupV1MockBad__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginCloneableSetupV2Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginCloneableSetupV1Mock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/AddresslistMock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TestSharedPlugin__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TestIdGatingCondition__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/RegistryUtils__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/RatioTest__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/InterfaceBasedRegistryMock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PermissionManagerTest__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PermissionConditionMock__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TestParameterScopingPermissionCondition__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/DAORegistry__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/DAOFactory__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IPluginSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginSetupProcessor__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IPluginRepo__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginRepoFactory__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginRepoRegistry__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PluginRepo__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/ENSSubdomainRegistrar__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/InterfaceBasedRegistry__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TokenFactory__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/MerkleMinter__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IMerkleDistributor__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IMerkleMinter__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/MerkleDistributor__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/Addresslist__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/CounterV1__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/CounterV1PluginSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/CounterV2__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/CounterV2PluginSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/MultiplyHelper__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/PlaceholderSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/AdminSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/Admin__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/Multisig__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IMultisig__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/MultisigSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TokenVoting__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/TokenVotingSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/MajorityVotingBase__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/AddresslistVoting__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/AddresslistVotingSetup__factory.ts, build/v1.0.0_mainnet_goerli/types/factories/IMajorityVoting__factory.ts, build/v1.0.0_mumbai/types/factories/GovernanceERC20__factory.ts, build/v1.0.0_mumbai/types/factories/IGovernanceWrappedERC20__factory.ts, build/v1.0.0_mumbai/types/factories/GovernanceWrappedERC20__factory.ts, build/v1.0.0_mumbai/types/factories/IERC20MintableUpgradeable__factory.ts, build/v1.0.0_mumbai/types/factories/IEIP4824__factory.ts, build/v1.0.0_mumbai/types/factories/DAO__factory.ts, build/v1.0.0_mumbai/types/factories/IDAO__factory.ts, build/v1.0.0_mumbai/types/factories/PluginCloneable__factory.ts, build/v1.0.0_mumbai/types/factories/Plugin__factory.ts, build/v1.0.0_mumbai/types/factories/IPlugin__factory.ts, build/v1.0.0_mumbai/types/factories/IProposal__factory.ts, build/v1.0.0_mumbai/types/factories/Proposal__factory.ts, build/v1.0.0_mumbai/types/factories/ProposalUpgradeable__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeable__factory.ts, build/v1.0.0_mumbai/types/factories/DaoAuthorizable__factory.ts, build/v1.0.0_mumbai/types/factories/DaoAuthorizableUpgradeable__factory.ts, build/v1.0.0_mumbai/types/factories/IMembership__factory.ts, build/v1.0.0_mumbai/types/factories/CallbackHandler__factory.ts, build/v1.0.0_mumbai/types/factories/IPermissionCondition__factory.ts, build/v1.0.0_mumbai/types/factories/PermissionLib__factory.ts, build/v1.0.0_mumbai/types/factories/PermissionManager__factory.ts, build/v1.0.0_mumbai/types/factories/TestERC721__factory.ts, build/v1.0.0_mumbai/types/factories/TestERC1155__factory.ts, build/v1.0.0_mumbai/types/factories/TestERC20__factory.ts, build/v1.0.0_mumbai/types/factories/GovernanceERC20Mock__factory.ts, build/v1.0.0_mumbai/types/factories/CallbackHandlerMockHelper__factory.ts, build/v1.0.0_mumbai/types/factories/DAOMock__factory.ts, build/v1.0.0_mumbai/types/factories/GasConsumer__factory.ts, build/v1.0.0_mumbai/types/factories/ERC1271Mock__factory.ts, build/v1.0.0_mumbai/types/factories/ActionExecute__factory.ts, build/v1.0.0_mumbai/types/factories/AdminCloneFactory__factory.ts, build/v1.0.0_mumbai/types/factories/MajorityVotingMock__factory.ts, build/v1.0.0_mumbai/types/factories/TestPlugin__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeableV1Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeableV3Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeableV2Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeableSetupV4Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeableSetupV3Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeableSetupV2Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeableSetupV1MockBad__factory.ts, build/v1.0.0_mumbai/types/factories/PluginUUPSUpgradeableSetupV1Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginCloneableV2Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginCloneableV1MockBad__factory.ts, build/v1.0.0_mumbai/types/factories/PluginCloneableV1Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginCloneableSetupV1MockBad__factory.ts, build/v1.0.0_mumbai/types/factories/PluginCloneableSetupV2Mock__factory.ts, build/v1.0.0_mumbai/types/factories/PluginCloneableSetupV1Mock__factory.ts, build/v1.0.0_mumbai/types/factories/AddresslistMock__factory.ts, build/v1.0.0_mumbai/types/factories/TestSharedPlugin__factory.ts, build/v1.0.0_mumbai/types/factories/TestIdGatingCondition__factory.ts, build/v1.0.0_mumbai/types/factories/RegistryUtils__factory.ts, build/v1.0.0_mumbai/types/factories/RatioTest__factory.ts, build/v1.0.0_mumbai/types/factories/InterfaceBasedRegistryMock__factory.ts, build/v1.0.0_mumbai/types/factories/PermissionManagerTest__factory.ts, build/v1.0.0_mumbai/types/factories/PermissionConditionMock__factory.ts, build/v1.0.0_mumbai/types/factories/TestParameterScopingPermissionCondition__factory.ts, build/v1.0.0_mumbai/types/factories/DAORegistry__factory.ts, build/v1.0.0_mumbai/types/factories/DAOFactory__factory.ts, build/v1.0.0_mumbai/types/factories/PluginSetup__factory.ts, build/v1.0.0_mumbai/types/factories/IPluginSetup__factory.ts, build/v1.0.0_mumbai/types/factories/PluginSetupProcessor__factory.ts, build/v1.0.0_mumbai/types/factories/IPluginRepo__factory.ts, build/v1.0.0_mumbai/types/factories/PluginRepoFactory__factory.ts, build/v1.0.0_mumbai/types/factories/PluginRepoRegistry__factory.ts, build/v1.0.0_mumbai/types/factories/PluginRepo__factory.ts, build/v1.0.0_mumbai/types/factories/ENSSubdomainRegistrar__factory.ts, build/v1.0.0_mumbai/types/factories/InterfaceBasedRegistry__factory.ts, build/v1.0.0_mumbai/types/factories/TokenFactory__factory.ts, build/v1.0.0_mumbai/types/factories/MerkleMinter__factory.ts, build/v1.0.0_mumbai/types/factories/IMerkleDistributor__factory.ts, build/v1.0.0_mumbai/types/factories/IMerkleMinter__factory.ts, build/v1.0.0_mumbai/types/factories/MerkleDistributor__factory.ts, build/v1.0.0_mumbai/types/factories/Addresslist__factory.ts, build/v1.0.0_mumbai/types/factories/CounterV1__factory.ts, build/v1.0.0_mumbai/types/factories/CounterV1PluginSetup__factory.ts, build/v1.0.0_mumbai/types/factories/CounterV2__factory.ts, build/v1.0.0_mumbai/types/factories/CounterV2PluginSetup__factory.ts, build/v1.0.0_mumbai/types/factories/MultiplyHelper__factory.ts, build/v1.0.0_mumbai/types/factories/PlaceholderSetup__factory.ts, build/v1.0.0_mumbai/types/factories/AdminSetup__factory.ts, build/v1.0.0_mumbai/types/factories/Admin__factory.ts, build/v1.0.0_mumbai/types/factories/Multisig__factory.ts, build/v1.0.0_mumbai/types/factories/IMultisig__factory.ts, build/v1.0.0_mumbai/types/factories/MultisigSetup__factory.ts, build/v1.0.0_mumbai/types/factories/TokenVoting__factory.ts, build/v1.0.0_mumbai/types/factories/TokenVotingSetup__factory.ts, build/v1.0.0_mumbai/types/factories/MajorityVotingBase__factory.ts, build/v1.0.0_mumbai/types/factories/AddresslistVoting__factory.ts, build/v1.0.0_mumbai/types/factories/AddresslistVotingSetup__factory.ts, build/v1.0.0_mumbai/types/factories/IMajorityVoting__factory.ts)
created dist, dist in 5.9s

npm/index.ts → dist...
[!] Error: 'GovernanceERC20Interface' is not exported by build/v1.0.0_mumbai/types/GovernanceERC20.d.ts, imported by build/v1.0.0_mumbai/types/factories/GovernanceERC20__factory.ts
https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module
build/v1.0.0_mumbai/types/factories/GovernanceERC20__factory.ts
Error: 'GovernanceERC20Interface' is not exported by build/v1.0.0_mumbai/types/GovernanceERC20.d.ts, imported by build/v1.0.0_mumbai/types/factories/GovernanceERC20__factory.ts
    at error (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:198:30)
    at Module.error (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:12477:16)
    at Module.traceVariable (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:12835:29)
    at ModuleScope.findVariable (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:11465:39)
    at FunctionScope.findVariable (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:6433:38)
    at Identifier.bind (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:7724:40)
    at AssignmentPattern.bind (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:5298:23)
    at FunctionDeclaration.bind (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:5294:31)
    at Program.bind (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:5294:31)
    at Module.bindReferences (/Users/michaelheuer/Projects/Aragon/osx/node_modules/rollup/dist/shared/rollup.js:12473:18)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

heueristik

Wrote a suggestion comment in the commit_hashes.json file.
When testing with @Rekard0, we found that the import of the typechain files might need some improvement.

Very nice that we have this package now ✊

packages/contracts-versions/commit_hashes.json

heueristik

I tested this by using it in my PR #355.
Nice, that we have this now

packages/contracts-versions/test/usage.test.ts

josemarinas

Looks good, thank you :)

Rekard0 added 15 commits April 25, 2023 12:20

prepare package

1b14d42

remember the branch

9d73698

only artifact src

fe9fe0f

correct the paths

c8f10de

correct root path

c878bf4

update hashes

f319e0c

add logs

3575258

only copy typechain

1c6b6f8

generate typechain

9f961cc

setup rollup

e8d6590

update npm packages

930b436

update rollup index

5db940f

add esm cjs

4dc131e

add readme

6005f06

remove gitIgnore

748b382

heueristik suggested changes Apr 27, 2023

View reviewed changes

packages/contracts-versions/commit_hashes.json Outdated Show resolved Hide resolved

Rekard0 added 12 commits April 27, 2023 16:13

update typechain

f9858c7

update typescript

1653ca1

convert script to typescript

03ad311

change commit hash json

5dd35fe

rename types to typechain

252b165

add test

ab50a5e

add json to rollup and export types

0ad3a4f

update usage test

b9230a7

generate index.ts dynamically

30c9593

update readme

50e094c

add empty line

744f4f7

fix index.ts

62f5bdb

heueristik previously approved these changes Apr 28, 2023

View reviewed changes

heueristik requested a review from josemarinas April 28, 2023 14:07

heueristik reviewed Apr 28, 2023

View reviewed changes

packages/contracts-versions/test/usage.test.ts Show resolved Hide resolved

ci/cd for tests

e49550f

Rekard0 dismissed heueristik’s stale review via e49550f May 2, 2023 09:11

Rekard0 added 8 commits May 2, 2023 11:13

fix-typo

e671daa

remove check formatting

5f3690b

add checkout ref

8eee478

update contracts flow

2358a73

update contracts workflow

062edcf

update contracts prettier config

8de1a63

remove directories

8029364

remove more dir

4b94376

Rekard0 requested review from mathewmeconry and heueristik May 2, 2023 12:45

josemarinas approved these changes May 2, 2023

View reviewed changes

heueristik approved these changes May 2, 2023

View reviewed changes

Rekard0 merged commit 5e7a19e into develop May 2, 2023

heueristik deleted the f/OS-380_npm_package_versions branch August 1, 2023 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

F/ OS-380 npm package versions #361

F/ OS-380 npm package versions #361

Rekard0 commented Apr 26, 2023 •

edited

Loading

heueristik commented Apr 26, 2023

heueristik left a comment

heueristik left a comment

josemarinas left a comment

F/ OS-380 npm package versions #361

F/ OS-380 npm package versions #361

Conversation

Rekard0 commented Apr 26, 2023 • edited Loading

Description

Type of change

Checklist:

heueristik commented Apr 26, 2023

heueristik left a comment

Choose a reason for hiding this comment

heueristik left a comment

Choose a reason for hiding this comment

josemarinas left a comment

Choose a reason for hiding this comment

Rekard0 commented Apr 26, 2023 •

edited

Loading