Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProposalCreated event dates #369

Merged
merged 128 commits into from
May 19, 2023
Merged

Fix ProposalCreated event dates #369

merged 128 commits into from
May 19, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented May 5, 2023 •
edited by jira bot
Loading

Description

Fix for https://discord.com/channels/672466989217873929/1102145446962540565

Task: OS-409

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

heueristik and others added 30 commits April 17, 2023 11:24
@heueristik
feat: protect the DAO executor against reentrancy
dd7a0dc
@heueristik
fix: remove console.log
ad2fd40
@heueristik
fix: prevent storage corruption
616b8bf
@heueristik
feat: refactored reentrancy guard into a modifier
e45854c
@heueristik
feat: added tests and preliminary versioning
2ac2262
@heueristik
chore: cleaning
9fb0473
@heueristik
fix: remove empty comment
a025523
@heueristik
fix: refactor findEventTopicLog function
3fcc083
@heueristik
fix: moved implementation slot and renamed file
02711cc
@heueristik
fix: remove redundant includes
360079c
@Rekard0
prepare package
1b14d42
@Rekard0
remember the branch
9d73698
@Rekard0
only artifact src
fe9fe0f
@Rekard0
correct the paths
c8f10de
@Rekard0
correct root path
c878bf4
@Rekard0
update hashes
f319e0c
@Rekard0
add logs
3575258
@Rekard0
only copy typechain
1c6b6f8
@Rekard0
generate typechain
9f961cc
@Rekard0
setup rollup
e8d6590
@Rekard0
update npm packages
930b436
@heueristik
Merge branch 'develop' into feature/OS-358-nonreentrant-executor
049ecc6
@Rekard0
update rollup index
5db940f
@Rekard0
add esm cjs
4dc131e
@Rekard0
add readme
6005f06
@Rekard0
remove gitIgnore
748b382
@heueristik
Merge branch 'f/OS-380_npm_package_versions' into feature/OS-358-nonr…
f78ad2c 
…eentrant-executor
@Rekard0
update typechain
f9858c7
@Rekard0
update typescript
1653ca1
@Rekard0
convert script to typescript
03ad311
@heueristik
fix: typo
8566eec
@heueristik
fix: delete legacy files
0604694
@heueristik
revert: metadata changes as they will happen in #375
8b51d4b
@heueristik
Merge remote-tracking branch 'origin/develop' into feature/OS-358-non…
263bc1b 
…reentrant-executor
@heueristik
fix: merge conflicts
0e1128a
@heueristik
fix: re-order changelog entries
3c64f8e
@heueristik
fix: remove wrong/redundant import originating from merge
d08e1ee
@heueristik
feat: improve upgrade version checks
cc571dc
@heueristik
fix: remove redundant ROOT_PERMISSION grant call
649732b
@heueristik
feat: added more checks to the upgrade tests
c275b62
@heueristik
feat: more explicit variable naming
a97a9ba
@heueristik
Merge remote-tracking branch 'origin/develop' into feature/OS-409-pro…
a84625b 
…posal-created-event-dates
@heueristik
fix: reworked initializeFrom logic
7c3e22c
@heueristik
Merge branch 'develop' into feature/OS-409-proposal-created-event-dates
717d30e
@heueristik
Merge branch 'feature/OS-358-nonreentrant-executor' into feature/OS-4…
ea3be72 
…09-proposal-created-event-dates
@heueristik heueristik marked this pull request as ready for review May 17, 2023 11:20
brickpop
brickpop previously approved these changes May 18, 2023
View reviewed changes
Rekard0
Rekard0 approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heueristik heueristik merged commit 0ddff1b into develop May 19, 2023
@heueristik heueristik deleted the feature/OS-409-proposal-created-event-dates branch May 19, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @brickpop @Rekard0