Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typechain and contracts tests #374

Merged
merged 14 commits into from
May 16, 2023
Merged

Fix typechain and contracts tests #374

merged 14 commits into from
May 16, 2023

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented May 12, 2023

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@heueristik heueristik force-pushed the fix/fix-typechain-and-contracts-tests branch from d54db73 to df4a9e3 Compare May 12, 2023 14:08
@heueristik heueristik force-pushed the fix/fix-typechain-and-contracts-tests branch from 10b7c75 to c1088ef Compare May 12, 2023 15:01
@heueristik heueristik marked this pull request as ready for review May 12, 2023 15:05
heueristik
heueristik previously approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments so I approved already to signal that we can merge.
(Since I committed to this branch, my approval will not count anyway)

brickpop
brickpop reviewed May 15, 2023
View reviewed changes
packages/contracts/deploy/new/00_managing-dao/00_managing-dao.ts Show resolved Hide resolved
packages/contracts/deploy/new/20_permissions/10_dao-registry-permissions.ts Show resolved Hide resolved
packages/contracts/deploy/new/40_finalize-managing-dao/00_grant-permissions.ts Outdated Show resolved Hide resolved
packages/contracts/deploy/new/40_finalize-managing-dao/30_install-multisig-on-managing-dao.ts Outdated Show resolved Hide resolved
packages/contracts/deploy/new/40_finalize-managing-dao/40_revoke-permissions.ts Outdated Show resolved Hide resolved
packages/contracts/src/test/osx-versions/Migration.sol Show resolved Hide resolved
packages/contracts/test/framework/dao/dao-registry.ts Show resolved Hide resolved
packages/contracts/test/framework/plugin/plugin-repo.ts Show resolved Hide resolved
packages/contracts/test/plugins/governance/admin/admin-setup.ts Show resolved Hide resolved
packages/subgraph/package.json Show resolved Hide resolved
heueristik
heueristik reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the changes that were made

packages/contracts/README.md Outdated Show resolved Hide resolved
packages/contracts/README.md Outdated Show resolved Hide resolved
packages/contracts/src/test/osx-versions/Migration.sol Outdated Show resolved Hide resolved
@heueristik heueristik changed the title Fix/fix typechain and contracts tests Fix typechain and contracts tests May 15, 2023
heueristik
heueristik previously approved these changes May 15, 2023
View reviewed changes
brickpop
brickpop reviewed May 15, 2023
View reviewed changes
packages/contracts/README.md Show resolved Hide resolved
packages/contracts/README.md Outdated Show resolved Hide resolved
brickpop
brickpop reviewed May 15, 2023
View reviewed changes
packages/contracts/README.md Outdated Show resolved Hide resolved
packages/contracts/README.md Outdated Show resolved Hide resolved
packages/contracts/README.md Outdated Show resolved Hide resolved
@Rekard0 Rekard0 merged commit f1c95ef into develop May 16, 2023
@brickpop brickpop deleted the fix/fix-typechain-and-contracts-tests branch May 16, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
contracts subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rekard0 @brickpop @heueristik