Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation generation workflow #379

Merged
merged 1 commit into from
May 17, 2023
Merged

Fix documentation generation workflow #379

merged 1 commit into from
May 17, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented May 16, 2023 •
edited by jira bot
Loading

Description

Task: OS-435

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@heueristik heueristik force-pushed the fix/OS-435-docgen branch 3 times, most recently from 7e1d0cd to ca2d83c Compare May 16, 2023 20:39
Rekard0
Rekard0 approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brickpop brickpop merged commit ceafa0e into develop May 17, 2023
@brickpop brickpop deleted the fix/OS-435-docgen branch May 17, 2023 15:39
@heueristik heueristik mentioned this pull request May 17, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @brickpop @Rekard0