Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set providers defensively #175

Merged
merged 1 commit into from
May 22, 2023
Merged

Set providers defensively #175

merged 1 commit into from
May 22, 2023

Conversation

mmjee
Copy link
Contributor

@mmjee mmjee commented May 22, 2023 •
edited by jira bot
Loading

PR

Describe your changes

See ticket. Some wallets don't allow modification of window.ethereum or such.

Issue ticket number and link

Checklist before requesting a review

  • You have performed a self-review of your own code
  • You are using approved terminology
  • Your changes have been tested locally
  • Your code builds clean without any errors or warnings

@netlify
Copy link

netlify bot commented May 22, 2023 •
edited
Loading

✅ Deploy Preview for authsdk-ref-guide ready!

Name Link
🔨 Latest commit 1a06421
🔍 Latest deploy log https://app.netlify.com/sites/authsdk-ref-guide/deploys/646b4e49e37a3500085d6eac
😎 Deploy Preview https://deploy-preview-175--authsdk-ref-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 22, 2023 •
edited
Loading

✅ Deploy Preview for dev-authsdk-ref-guide ready!

Name Link
🔨 Latest commit 1a06421
🔍 Latest deploy log https://app.netlify.com/sites/dev-authsdk-ref-guide/deploys/646b4e49fbd7550008f3ddba
😎 Deploy Preview https://deploy-preview-175--dev-authsdk-ref-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmjee mmjee merged commit aa15153 into dev May 22, 2023
@mmjee mmjee deleted the mmjee/set-providers-defensively branch May 22, 2023 11:53
@mmjee mmjee restored the mmjee/set-providers-defensively branch May 22, 2023 11:53
@mmjee mmjee deleted the mmjee/set-providers-defensively branch May 22, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makylfang makylfang makylfang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmjee @makylfang