Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add reconnect functions #192

Merged
merged 2 commits into from
Jun 29, 2023
Merged

[Fix] Add reconnect functions #192

merged 2 commits into from
Jun 29, 2023

Conversation

makylfang
Copy link
Contributor

PR

Describe your changes

  • Added reconnect() and canReconnect() fn
  • Added storing session expiry

Checklist before requesting a review

  • You have performed a self-review of your own code
  • You are using approved terminology
  • Your changes have been tested locally
  • Your code builds clean without any errors or warnings

mmjee
mmjee reviewed Jun 28, 2023
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@makylfang makylfang requested a review from mmjee June 29, 2023 06:29
mmjee
mmjee approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@mmjee mmjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@makylfang makylfang merged commit c11a14f into mmjee/AR-6412-session-id-handling-in-the-auth-sdk Jun 29, 2023
@makylfang makylfang deleted the fix/add-reconnect-fn branch June 29, 2023 07:46
mmjee added a commit that referenced this pull request Jul 3, 2023
@mmjee @makylfang
Session ID handling & Reconnection (#190)
3940756 
* 3PC Blockage mitigation

* Automatically open reconnection popups ASAP

* Removed debug

* [Fix] Add reconnect functions (#192)

* Added storing session exp, added reconnect() and canReconnect() fn

* Added fetching of reconnection url from wallet

---------

Co-authored-by: makylfang <makyl@newfang.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmjee mmjee mmjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makylfang @mmjee