-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Derive name of positional arguments from property name #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks real nice! Just one suggestion for the typing.
Regarding the display, hyphenating would probably be a good idea, but no need to make it configurable as it'll be purely aesthetic anyway, so I'd say the less configuration overhead the better in this case.
Not so sure about hyphenating anymore. I think this is good as-is. |
Sounds good, let's try like this 👍 |
Co-Authored-By: Maël Nison <nison.mael@gmail.com>
Ref: yarnpkg/berry#371 (comment)
Nice-to-have?:
[ ] hyphenate names[ ] make name configurable@Command.String({ name: 'workspace-name' })
or@Command.String('workspace-name')
. Though the second variant requires more work since the library currently assumes that named arguments are optional.