Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Ensure BoardListWatch gRPC call correctly release resources #2681

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 31, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

It's a bugfix to a regression: the gRPC API call BoardListWatch kept the packagemanager locked until the watcher was closed.

What is the current behavior?

What is the new behavior?

The packagemanager is released right after the board watcher feed is obtained.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie self-assigned this Jul 31, 2024
@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: gRPC Related to the gRPC interface labels Jul 31, 2024
@cmaglie cmaglie added this to the Arduino CLI v1.0.4 milestone Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.24%. Comparing base (cbec871) to head (a410977).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2681   +/-   ##
=======================================
  Coverage   70.23%   70.24%           
=======================================
  Files         222      222           
  Lines       21348    21345    -3     
=======================================
  Hits        14993    14993           
+ Misses       5176     5174    -2     
+ Partials     1179     1178    -1     
Flag Coverage Δ
unit 70.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit faa6359 into arduino:master Jul 31, 2024
98 checks passed
@cmaglie cmaglie deleted the fix_board_watch_grpc branch July 31, 2024 14:35
@cmaglie cmaglie added the conclusion: resolved Issue was resolved label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants