Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shader error when loading InstanceedSkinnedMesh #46

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: shader error when loading InstanceedSkinnedMesh #46

merged 2 commits into from
Mar 19, 2024

Conversation

piellardj
Copy link
Member

This PR fixes a shader compilation error when loading InstancedSkinnedMesh with three.js v162.
I believe this is a bug introduced in three.js v162.

This is probably is a temporary fix because:

  • this bug was introduced in the currently latest three.js v162 (see PR InstancedMesh: Add support for morph targets. mrdoob/three.js#27669), so it is quite new, so there is a high chance they will fix this bug.
  • three.js v162 added support for instanced meshes. There is a chance they will also add proper support for instanced skinned meshes soon.

@piellardj piellardj requested a review from Sceat March 18, 2024 16:59
@piellardj piellardj self-assigned this Mar 18, 2024
@piellardj piellardj linked an issue Mar 18, 2024 that may be closed by this pull request
Shader error when loading glb models #11
Closed
@piellardj piellardj mentioned this pull request Mar 18, 2024
Closed
Sceat
Sceat approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@Sceat Sceat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ! 🎉

@Sceat Sceat merged commit dcce135 into master Mar 19, 2024
@Sceat Sceat deleted the fix/shader_error branch March 19, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sceat Sceat Sceat approved these changes

Assignees

@piellardj piellardj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shader error when loading glb models
2 participants
@piellardj @Sceat