Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotkey to invert "Add dates as link?" option #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jose-elias-alvarez
Copy link

Motivation for this PR: I'm using the Add dates as link? option, and 95% of the time, I do want to insert a link, but for the other 5%, it's tedious to delete the automatically inserted brackets.

Accordingly, this PR adds Alt as a hotkey modifier for the suggestion modal (like the current Shift hotkey) to do one of two things if held on confirmation:

  1. If the user has enabled the option in question, it inserts the date as plain text
  2. If the user has not enabled the option, it inserts the date as a link (to help users in the opposite situation who may occasionally want to insert a link)

I also considered using a separate trigger character for "inverted" insertions, but I felt that adding a hotkey to the modal was the least intrusive option (and has the advantages of requiring no additional configuration + having a higher level of discoverability).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant