This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Fix syntax error in Teams notifications #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a trailing comma at the end of the condition fact value which made the JSON syntactically invalid causing notifications to not be handled / published.
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 60.37% 60.37%
=======================================
Files 13 13
Lines 636 636
=======================================
Hits 384 384
Misses 182 182
Partials 70 70 Continue to review full report at Codecov.
|
ryota-sakamoto
approved these changes
May 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a trailing comma at the end of the condition fact value
which made the JSON syntactically invalid causing notifications
to not be handled / published.