Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on-cluster workflow test to CI #887

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Add on-cluster workflow test to CI #887

merged 10 commits into from
Dec 12, 2023

Conversation

elliotgunton
Copy link
Collaborator

@elliotgunton elliotgunton commented Dec 8, 2023

Pull Request Checklist

Description of PR
Introduce local Argo cluster workflow tests to CI, and make targets to set up a local cluster for testing (this worked very well on GitHub codespaces, where I could even get a web UI to the cluster).

Added a single test to confirm the workflow runs via create and reaches the succeeded status.phase. We can think about creating a more flexible/extensible framework for adding on_cluster tests -

  • I'd like to use a subset of our examples
  • But we want to assert on more than the status.phase, e.g. output values, running order, skipped nodes etc, which would require bespoke tests for each
  • It would also be good to have a wrapper for fetching these values, e.g. getting a node requires iterating through the status.nodes dictionary, which is keyed by hashes, so you have to check displayName from the values.

@elliotgunton elliotgunton added semver:patch A change requiring a patch version bump type:task A general task labels Dec 8, 2023
@elliotgunton elliotgunton force-pushed the workflows-cicd branch 6 times, most recently from 9418063 to 9662192 Compare December 8, 2023 17:49
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@flaviuvadan flaviuvadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great as a first version!

Also def open to k3d as Sam mentioned

Makefile Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19fa389) 79.7% compared to head (5a61b08) 79.7%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #887   +/-   ##
=====================================
  Coverage   79.7%   79.7%           
=====================================
  Files         45      45           
  Lines       3722    3722           
  Branches     754     754           
=====================================
  Hits        2970    2970           
  Misses       558     558           
  Partials     194     194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@elliotgunton elliotgunton changed the title [DRAFT] Workflows cicd Add on-cluster workflow test to CI Dec 12, 2023
@elliotgunton elliotgunton marked this pull request as ready for review December 12, 2023 12:04
@elliotgunton elliotgunton added the github_actions Pull requests that update GitHub Actions code label Dec 12, 2023
Copy link
Collaborator

@flaviuvadan flaviuvadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! The next iteration can address some of the other concerns you mentioned in the description. Thx again for adding this <3

@elliotgunton elliotgunton merged commit a8edc84 into main Dec 12, 2023
24 checks passed
@elliotgunton elliotgunton deleted the workflows-cicd branch December 12, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Argo Workflows into Hera's CI
3 participants