Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1375 - Error view instead of blank page in UI #1726

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Issue #1375 - Error view instead of blank page in UI #1726

merged 3 commits into from
Jun 11, 2019

Conversation

AdityaGupta1
Copy link
Contributor

Closes #1375

If an error causes the UI to crash, a page with the stacktrace and a link to submit a new issue is shown, for example:

image

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #1726 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1726   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files          77       77           
  Lines       11433    11433           
=======================================
  Hits         3903     3903           
  Misses       6989     6989           
  Partials      541      541

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88231bc...223e4b1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #1726 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1726   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files          77       77           
  Lines       11433    11433           
=======================================
  Hits         3903     3903           
  Misses       6989     6989           
  Partials      541      541

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88231bc...223e4b1. Read the comment docs.

@alexec alexec requested a review from alexmt June 10, 2019 22:42
@alexec alexec added this to the v1.1 milestone Jun 10, 2019
ui/src/app/app.tsx Show resolved Hide resolved
@alexec alexec merged commit e57fa0c into argoproj:master Jun 11, 2019
@AdityaGupta1 AdityaGupta1 deleted the ui-error-view branch June 11, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error view instead of blank page in UI
2 participants