Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for destination port #288

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add support for destination port #288

wants to merge 1 commit into from

Conversation

sc68cal
Copy link

@sc68cal sc68cal commented Sep 14, 2023

No description provided.

dlyssenko
dlyssenko requested changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@dlyssenko dlyssenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sc68cal, the PR looks good, but we also need a respective unit test for this. Could you, please also add a unit test case for dst port, so that I could approve your PR?
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlyssenko dlyssenko dlyssenko requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc68cal @dlyssenko