Skip to content

Commit

Permalink
Merge pull request #617 from arlyon/arlyon/bump-msrv
Browse files Browse the repository at this point in the history
bump msrv since openssl fails to compile
  • Loading branch information
arlyon authored Sep 24, 2024
2 parents af7b0f8 + 1fcbb29 commit a414e86
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ body:
id: language-version
attributes:
label: Rust version
placeholder: Our MSRV is 1.74.0
placeholder: Our MSRV is 1.78.0
validations:
required: true
- type: input
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/async-stripe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@v1
with:
toolchain: "1.74.0"
toolchain: "1.78.0"
- uses: actions/cache@v4
with:
path: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
token: ${{ secrets.REPO_SCOPED_TOKEN }}
- uses: dtolnay/rust-toolchain@v1
with:
toolchain: "1.74.0"
toolchain: "1.78.0"
- uses: cycjimmy/semantic-release-action@v4
with:
extra_plugins: |
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ members = [
name = "async-stripe"
version = "0.39.1"
description = "API bindings for the Stripe HTTP API"
rust-version = "1.74.0"
rust-version = "1.78.0"
authors = [
"Anna Baldwin <abaldwin@developers.wyyerd.com>",
"Kevin Stenerson <kestred@users.noreply.github.com>",
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ If you don't see the specific version you are on, prefer the next available vers

## MSRV

We currently have `1.74.0` pinned in CI, so any version of rustc newer than that should work.
We currently have `1.78.0` pinned in CI, so any version of rustc newer than that should work.
If this is not the case, please open an issue. As a policy, we permit MSRV increases in non-breaking releases.
If you have a compelling usecase for bumping it, we are usually open to do so, as long as
the rust version is not too new (generally 3 releases).
Expand Down
2 changes: 1 addition & 1 deletion src/client/stripe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ impl Client {

fn create_request(&self, method: Method, url: Url) -> Request {
let mut req = Request::new(method, url);
req.insert_header("authorization", &format!("Bearer {}", self.secret_key));
req.insert_header("authorization", format!("Bearer {}", self.secret_key));

for (key, value) in self.headers.to_array().iter().filter_map(|(k, v)| v.map(|v| (*k, v))) {
req.insert_header(key, value);
Expand Down
5 changes: 3 additions & 2 deletions src/resources/payment_source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ use crate::params::Object;
use crate::resources::{Account, BankAccount, Card, Currency, Source};

/// A PaymentSourceParams represents all of the supported ways that can
/// be used to creating a new customer with a payment method or creating
/// a payment method directly for a customer via `Customer::attach_source`.
/// be used.
///
/// This includes creating a new customer with a payment method or creating
/// a payment method directly for a customer via `Customer::attach_source`.
/// Not to be confused with `SourceParams` which is used by `Source::create`
/// to create a source that is not necessarily attached to a customer.
#[derive(Clone, Debug, Serialize, Deserialize)]
Expand Down
11 changes: 10 additions & 1 deletion tests/encoding.rs
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ fn deserialize_customer_with_source() {
}

#[test]
#[cfg(feature = "event")]
#[cfg(feature = "events")]
fn deserialize_checkout_event() {
use stripe::Event;

Expand All @@ -277,6 +277,15 @@ fn deserialize_checkout_event() {
"data": {
"object": {
"id": "cs_00000000000000",
"created": 1649316731,
"expires_at": 1649316731,
"shipping_options": [],
"custom_fields": [],
"custom_text": {},
"automatic_tax": {
"enabled": false,
"created": 1649316731,
},
"object": "checkout.session",
"billing_address_collection": null,
"cancel_url": "https://example.com/cancel",
Expand Down

0 comments on commit a414e86

Please sign in to comment.