-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename board config: micro.csc to olimex-a20-olinuxino-micro #6254
Rename board config: micro.csc to olimex-a20-olinuxino-micro #6254
Conversation
Submitted upon request to make user's life easier
Its already there, hence closing - https://github.com/armbian/build/blob/main/config/boards/micro.csc |
$ diff ./config/boards/{olimex-a20-olinuxino-micro.csc,micro.csc}
5c5
< BOOTCONFIG="A20-OLinuXino_MICRO_defconfig"
---
> BOOTCONFIG="A20-OLinuXino_MICRO-eMMC_defconfig" |
Thanks for pointing it out. I see dts is almost the same. Only changes are in MMC_SLOT_EXTRA value, I think it may be possible to handle it in some other way like how multiple u-boots are done for clearfog. But even if there is no other way, this can cause confusion to users. Probably we also need to rename either the old board or the new one to avoid the confusion |
Also there might be changes needed in the comment on the top of the file? |
i've just done minimal changes so that the user can test the contribution and know what they are testing instead of being overwhelmed with changes that's why this is set as draft that shouldn't be subject to any review yet unless requested |
yes I noticed its draft and their will be changes coming. Not a review comment, was just pointing that out to make sure its not missed :) |
emmc variant can cover both. |
same as here and done. |
I'm building it right now |
It failed to compile Last ~70 lines (error): https://0x0.st/HkwG.txt full log: https://paste.armbian.com/xuwasitula |
use bullseye or bookworm instead of using buster |
Actually rather trixie or sid |
Otherwise we have this config for years, just its named micro.csc. I know its not correct, but why bother? Rename it. |
@Kreyren Rename micro.csc to this or close PR as we already have this hw, just named differently. |
@Goosegit11 were you able to test the image? |
@Kreyren Tried with bullseye, it booted, asked me "Create root password" and other questions, after this "installation" it doesn't boot anymore, sadly. And what do you think about what Igor says? |
🤔 afaik that happens if you kill the power to the system as it's resizing the rootfs partition during the first installation prompt (after root password) that then results in rootfs corruption. Can you try again?
He says lot of things.. we ain't at the state where i need to comment on things yet when the board doesn't work reliably |
Description
Submitted upon request to make user's life easier.
How Has This Been Tested?
No need. Just name adjustment and CSC board.
Checklist: