Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kernel config for khadas 1s/vim4 so that HA works #6313

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Feb 28, 2024

Description

Some network related dependency were missing as DNS within docker container was not working. While dealing with config, several other options were enabled, which should be harmless.

Jira reference number AR-2086

How Has This Been Tested?

  • Generated Debian Bookworm with HA extension which loads automatically

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... labels Feb 28, 2024
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug 05 Milestone: Second quarter release Needs review Seeking for review labels Feb 28, 2024
@igorpecovnik igorpecovnik changed the title Update kernel config for khadas 1s/vim4s so that HA works Update kernel config for khadas 1s/vim4 so that HA works Feb 28, 2024
@viraniac
Copy link
Collaborator

Thats too many things getting toggled. As I understood from Nick, the vendor kernel is too sensitive about what things are compiled as builtin and what are compiled as modules. Also when things are compiled as modules, they sometimes has to be loaded in some precise order. Hence I really don't think changing so many things is going to be a good idea. Also some changes doesn't make much sense. Like usb4 is being enabled, while the SoC has no support for usb 4.

Could you please share how you came up with all the things that needed to be toggled?

@igorpecovnik
Copy link
Member Author

Could you please share how you came up with all the things that needed to be toggled?

For outside network protocol related it was not scientific way, pure random. I'll push with minimal changes after the testing.

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/large PR with 250 lines or more labels Feb 28, 2024
Copy link
Collaborator

@viraniac viraniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Feb 28, 2024
@igorpecovnik igorpecovnik merged commit ffeb84f into main Feb 28, 2024
10 checks passed
@igorpecovnik igorpecovnik deleted the AR-2086 branch February 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Bugfix Pull request is fixing a bug Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

2 participants