-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build a magisk module as well; also some minor fixes: #8
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a8c490d
Merge pull request #2 from arovlad/development
arovlad 923c4e0
Merge pull request #3 from arovlad/development
arovlad ed9d9f9
Merge pull request #6 from arovlad/development
arovlad 59b37fe
build a magisk module as well; also some minor fixes:
infinity0 1e1f567
Update instructions for the Magisk module
infinity0 b5e2273
improved copywriting
arovlad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,35 @@ | ||
#!/bin/bash | ||
set -e | ||
|
||
if [ ! -f build/build.sh ]; then | ||
echo "Downloading toolkit" | ||
mv .git .git.bak &> /dev/null | ||
git init &> /dev/null | ||
git remote add origin https://github.com/phhusson/vendor_hardware_overlay.git &> /dev/null | ||
git fetch --depth=1 &> /dev/null | ||
git checkout origin/pie build &> /dev/null | ||
rm -f -r .git | ||
mv .git.bak .git &> /dev/null | ||
build/build.sh | ||
echo "Building flashable package" | ||
git clone --depth=1 https://github.com/phhusson/vendor_hardware_overlay.git | ||
( cd vendor_hardware_overlay && git checkout origin/pie build && mv build .. ) | ||
fi | ||
|
||
echo "Building overlay APK" | ||
( cd build && ./build.sh ../BromiteWebView/Android.mk ) | ||
|
||
echo "Building flashable package (zip)" | ||
mkdir build/.temp | ||
mkdir -p build/.temp/META-INF/com/google/android | ||
cp update-binary build/.temp/META-INF/com/google/android | ||
echo "# Dummy file; update-binary is a shell script." > build/.temp/META-INF/com/google/android/update-script | ||
echo "# Dummy file; update-binary is a shell script." > build/.temp/META-INF/com/google/android/updater-script | ||
mkdir -p build/.temp/system/addon.d | ||
cp 99-bromite-webview.sh build/.temp/system/addon.d | ||
mkdir -p build/.temp/vendor/overlay | ||
cp build/treble-overlay-bromite-webview.apk build/.temp/vendor/overlay | ||
( cd build/.temp && zip -r ../BromiteSystemWebViewOverlay.zip . ) &> /dev/null | ||
( cd build/.temp && zip -r - . > ../BromiteSystemWebViewOverlay.zip . ) &> /dev/null | ||
rm -r build/.temp | ||
|
||
echo "Building Magisk module (zip)" | ||
mkdir build/.temp | ||
mkdir -p build/.temp/META-INF/com/google/android | ||
curl -sL https://github.com/topjohnwu/Magisk/raw/master/scripts/module_installer.sh > build/.temp/META-INF/com/google/android/update-binary | ||
test -s build/.temp/META-INF/com/google/android/update-binary | ||
echo "#MAGISK" > build/.temp/META-INF/com/google/android/updater-script | ||
mkdir -p build/.temp/system/vendor/overlay | ||
cp build/treble-overlay-bromite-webview.apk build/.temp/system/vendor/overlay | ||
cp module.prop build/.temp/ | ||
( cd build/.temp && zip -r - . > ../BromiteSystemWebViewMagisk.zip . ) &> /dev/null | ||
rm -r build/.temp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
id=bromite-system-webview | ||
name=Bromite System WebView Overlay | ||
version=v0.3 | ||
versionCode=00003 | ||
author=arovlad | ||
description=Enable the use of Bromite as the system WebView |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording here should not be modified: root access and Magisk is still not required. This change should be dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is about the resource overlay, whereas how to install the overlay is a separate issue. So I think it's clearer to discuss what types of root access is required, in a different paragraph.
In fact, all installation methods require some type of root access. It is misleading from a security perspective to claim any of these methods "do not require [any type of] root access". More precisely, I think what you mean is that the custom recovery method means you don't require root access on your main system. This is fair, and I've amended the wording to say this, in a paragraph further below. But it is misleading to unconditionally say it "does not require root" with no other qualifiers - when I run
adb sideload
in custom recovery, this is effectively giving your script root access to my system, it modifies the system partitions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, what I meant was that it does not require a rooted device, so I would suggest replacing
with
while also keeping the mention about not needing Magisk. To reach a sort of compromise between our conflicting views about Magisk, I would suggest adding a paragraph below this line mentioning that if keeping Magisk for customisation purposes is the top-most priority for the user and or if there isn't any space available on the partition a Magisk module is included for convenience only. Please also mention that I do not endorse Magisk, eventually linking to this Reddit comment.
I am very skeptical about this addition though.