Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.4.1 Release #137

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Version 1.4.1 Release #137

wants to merge 4 commits into from

Conversation

BioWilko
Copy link
Collaborator

@BioWilko BioWilko commented Sep 2, 2024

ARTIC Fieldbioinformatics v1.4.1

Well hasn't this been a long time coming?

Major Changes:

  • Fieldbioinformatics now supports rapid barcoded (fragmented) primer trimming and normalisation
  • Nanopolish has been removed completely due to several compatibility issues
  • Medaka is now the recommended variant caller and will run by default
  • Clair3 has been added as an experimental variant caller (can be used by providing the --clair3 argument to artic minion. By default only r9.4.1 models are available but r10.4.1 models are available from the ONT Rerio repository.
  • Primer scheme fetcher has been updated to pull from the quick-lab primal hub schemes repository. For schemes not available in this repository you may provide them directly with the arguments --bed and --ref.
  • Automated docker builds pushing to quay.io for use in nextflow pipelines etc.
  • Remove some old functionality which is no longer relevant (basecalling, gather, etc)
  • Re-implement CI as a gh action.
  • Fix the overlapping variants issue by normalising variants against the pre-consensus using bcftools norm.
  • Fix the annoying longshot auto max cov bug by setting max cov to an arbitrarily high number (200000) if anyone has 200001 depth BAMs and this break things I apologise profusely and would love to know what you're trying to accomplish with this data.

BioWilko and others added 4 commits August 19, 2024 12:40
* Deprecate old tools and black format

* Support fragmented data

* use new trim primer arg in minion

* reverse the (revolting) primer position logic

* Fix find primer logic

* Improve the cursed report writer logic

* explicitly named function args, what a novel idea

* add temp debugging prints to find_primer

* Add logic to handle segments outside of primer scheme

* fix typo

* General bugfixes, test fix for overlapping variant issue

* add min mapq argument

* properly provide min_mapq to handle_segment

* Fix unmatched read group issue

* Fix 8 bit int error

* First attempt to integrate clair3 as optional
variant caller

* Slightly change env yaml format

* Specify env name in mamba gh action

* Checkout repo before installing env

* python 3.6.15

* Run on ubuntu 20.04

* unpin python

* Unpin python entirely

* Separate out tests

* correct unit test path

* remove retvar hints for compatibility

* Fix silly relative imports

* Switch to cyvcf and fix unit tests

* Fix pipeline parse unit test

* Fix fstring

* Large changes to make clair3 work, various unit test updates

* Fix fuzzy primer site match logic

* Fix minion_validator path

* Fix vcf merge bug with empty VCF files

* Increase fuzzy match default threshold to 20

* Fix CHROM bug in vcf merge properly

* Report failed workflow when variants are missed

* Fix vcf merge again

* Separate out tests

* No counter anymore

* Add C241T to SP1 variants

* Add limit on ref pileup

* Single copy of CVR1 12733 var

* re-enable other consensus tests

* First attempt to make minion validator less fragile

* Unify testvariants, improve test logic

* medaka has to be different smh

* Index ref fasta when using the clair3 workflow

* Add mean amplicon depth TSV output

* Update CLI and scheme fetcher

* Update align trim unit test

* Use proper version of V3 bedfile

* Fix pipeline unit test

* Fix align trim amp depth bug

* Call variants on non primertrimmed bam

* Don't test MT vs clair

* properly disable test

* Add docker build push action on release

* Grab wget in dockerfile

* Update docs and readme

* docker push on release only

* Remove debugging print statement

* Make fuzzy primer match logic clearer

* Install procps for nxf compatibility
* mods to Dockerfile

* wip

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment