Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Miri tests with strict provenance #156

Closed
lopopolo opened this issue Apr 18, 2022 · 2 comments · Fixed by #157
Closed

Run Miri tests with strict provenance #156

lopopolo opened this issue Apr 18, 2022 · 2 comments · Fixed by #157
Labels
A-build Area: CI build infrastructure. A-interner Area: String interners, data structures, and types.

Comments

@lopopolo
Copy link
Member

See:

The current hard mode is:

$ MIRIFLAGS="-Zmiri-strict-provenance -Zmiri-check-number-validity -Zmiri-symbolic-alignment-check -Zrandomize-layout" cargo +nightly miri test --test leak_drop

Blockers:
@lopopolo lopopolo added A-build Area: CI build infrastructure. A-interner Area: String interners, data structures, and types. labels Apr 18, 2022
@CAD97
Copy link
Contributor

CAD97 commented Apr 18, 2022

(-Zmiri-strict-provenance implies -Zmiri-check-number-validity now.)

In the meantime, you can use --target to avoid testing the macOS target. (Miri, as an interpreter VM, can test any target on any host.)

lopopolo added a commit that referenced this issue Apr 23, 2022
@lopopolo
Run Miri tests under strict provenance and randomize layout
be76472 
Fixes #156.
@lopopolo lopopolo mentioned this issue Apr 23, 2022
Merged
@lopopolo
Copy link
Member Author

Thanks for fixing this on macOS with rust-lang/rust#96167 @CAD97. The tests pass locally on my Mac for me now with rustc 1.62.0-nightly (f4ec0e7cf 2022-04-22).

PR to enable this is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build Area: CI build infrastructure. A-interner Area: String interners, data structures, and types.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run Miri tests under strict provenance and randomize layout artichoke/intaglio
2 participants
@lopopolo @CAD97