fix(artillery): update payload path when using environments #1964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #1961
How
This was happening because checkConfig gets called twice when you pass in a scenario + config. In that situation, if you have
environments
, the first timecheckConfig
gets called, it correctly creates thepayload
in the rootconfig
and replaces those paths.However, it doesn't do the same to
config.environments.payload
. So the second timecheckConfig
is called, the_.merge
overrides the payload path with theconfig.environment.payload
unresolved path, causing the issue.The PR addresses that by ensuring that it no longer gets called twice.
Testing
This was tested with the test scripts provided in the issue (very helpful), against Artillery Local.
Two things are missing:
create-bom.js
;