fix(types): implies default "http" engine, fixes request "cookies" and "match" #2054
Conversation
kettanaito
commented
Aug 16, 2023
kettanaito
commented
- Follow-up for fix(types): improve conformance to the specification #2051
| @@ -286,7 +286,7 @@ export type Scenario = { | |||
| /** | |||
| * @title HTTP engine | |||
| */ | |||
| engine: 'http'; | |||
| engine?: 'http'; | |||
There was a problem hiding this comment.
I'm still surprised this worked 🤔 We need to test this carefully but so far automated tests confirm the intention as valid.
|
This needs #2055 to be merged first because per schema, |
There was a problem hiding this comment.
A couple of small changes in the expect plugin, since you've typed that already.
Also, I released this last week:
938f9c4
Which means that now http defaults in config can be configured as config.http.defaults. Doesn't have to be addressed in this PR, but it might be something to add to the schema too. Docs for it are already here: https://www.artillery.io/docs/reference/engines/http#default-configuration
|
Hi, @bernardobridge. I've addressed the last two points, could you please take a look at this once more? Thank you. |
|
Encountered problematic tests, addressing in #2071 |
