Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fargate): improve cloudwatch retention policy user facing logs #2489

Merged

Conversation

bernardobridge
Copy link
Contributor

Description

As seen in #2486, there might be missing permissions in the role being used to run artillery CLI, which would cause a confusing warning with a stack trace, despite the test continuing to run. This makes the warning message more easy to understanding.

The warning will look something like this now:

Launching workers... [11:58:44]
Waiting for Fargate... [11:58:45]
⠇ 
User: arn:aws:sts::ACCOUNT_ID:assumed-role/ROLE_NAME/SESSION_NAME is not authorized to perform: logs:PutRetentionPolicy on resource: arn:aws:logs:us-east-1:ACCOUNT_ID:log-group:artilleryio-log-group/artilleryio-cluster:log-stream: because no identity-based policy allows the logs:PutRetentionPolicy action

WARNING: Missing logs:PutRetentionPolicy permission to set Cloudwatch retention policy. Please ensure the IAM role has the necessary permissions:
https://www.artillery.io/docs/load-testing-at-scale/aws-fargate#iam-permissions
The test will resume without setting the retention policy.

Waiting for workers to start: pending: 1 [11:59:16]
Waiting for workers to start: pending: 1 [11:59:27]

Pre-merge checklist

This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.

  • Does this require an update to the docs?
  • Does this require a changelog entry?

@bernardobridge bernardobridge merged commit 0a139ea into main Feb 13, 2024
15 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/oss-25-improve-cw-retention-error-handling branch February 13, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants