feat(playwright): use target as baseURL by default #2493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
target
will now be used as Playwright'sbaseURL
by default. This change makesartillery-engine-playwright
more consistent with Playwright (which allows thebaseURL
config option), and simplifies the job of reusing a Playwright test as an Artillery test, as you can simply set thetarget
as thebaseURL
option from your Playwright tests, and keep the test scripts the same.Testing
await page.goto('/docs')
).Note: I'll change some of the examples to leverage this when a new CLI version contains the change.
Pre-merge checklist